On Sun, 15 Mar 2026 22:44:37 GMT, xeu-giayoei <[email protected]> wrote:

> This PR fixes a segfault in the jpackage Linux launcher caused by partial 
> reads/writes when transferring JVM launcher data through a pipe.
> 
> It introduced `readFully` and `writeFully` helper functions in 
> `LinuxLauncher.c` to ensure complete transfer by:
> - Using a `while` loop to handle partial I/O.
> - Retrying on `EINTR`.

Changes requested by asemenyuk (Reviewer).

The fix looks good.

Can you add a test that triggers the `EINTR` error condition?

src/jdk.jpackage/linux/native/applauncher/LinuxLauncher.c line 1:

> 1: /*

The year in the copyright header needs to be updated from `Copyright (c) 2021,` 
to `Copyright (c) 2021, 2026,`

-------------

PR Review: https://git.openjdk.org/jdk/pull/30254#pullrequestreview-3955013755
PR Comment: https://git.openjdk.org/jdk/pull/30254#issuecomment-4068815047
PR Review Comment: https://git.openjdk.org/jdk/pull/30254#discussion_r2941399485

Reply via email to