On Fri, 13 Mar 2026 14:01:29 GMT, Matthias Baesken <[email protected]> wrote:
>> We use a struct DL_info on AIX (similar to the struct on Linux) to support >> dladdr, but currently it is available 3 times (even in slightly different >> versions). >> This should be unified and put into a single header. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Move comment make/common/modules/LauncherCommon.gmk line 45: > 43: LAUNCHER_CFLAGS += -I$(TOPDIR)/src/java.base/share/native/launcher \ > 44: -I$(TOPDIR)/src/java.base/share/native/libjli \ > 45: $(ADD_PLATFORM_INCLUDE_DIR) \ This seems an odd way of doing this to me. Why not just: ifeq ($(call isTargetOs, aix), true) LAUNCHER_CFLAGS += -I$(TOPDIR)/src/java.base/aix/native/include endif after the `LAUNCHER_CFLAGS` definition. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30220#discussion_r2938074742
