On Fri, 13 Mar 2026 19:28:43 GMT, Simon Tooke <[email protected]> wrote:

> test/jdk/java/lang/instrument/GetObjectSizeIntrinsicsTest.java
> 
> ARRAY_HEADER_SIZE is wrong for 32 bit. Should be 12 - 4 bytes mark word, 4 
> bytes klass, 4 bytes array length.  Any rounding required is not part of this 
> calculation.
> 
> Practically it does not matter for the test, since all values are aligned up 
> to object alignment anyway, which is hard-coded to 8 bytes for 32bit, and 
> cannot be smaller than machine word size on 64-bit. Just a clarity issue.

Good

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/30246#pullrequestreview-3948274373

Reply via email to