On Thu, 5 Mar 2026 23:47:49 GMT, Alexey Semenyuk <[email protected]> wrote:
>> Fix jpackage to use the correct arch for DEB bundles when running on
>> RPM-based Linux, and vice versa.
>>
>> The bug was in `jdk.jpackage.internal.LinuxBundlingEnvironment` class.
>>
>> Additionally:
>> - Add missing single quote escape to
>> `error.unexpected-default-package-property.advice` l10n string
>> - Reworded `error.unexpected-package-property` l10n string
>> - JPackageStringBundle: add `cannedFormattedStringAsPattern()`; throw when
>> the number of format arguments doesn't match the number of format fields;
>> add unit tests; ErrorTest, InstallDirTest: follow-up bugfixes
>> - LinuxHelper: fix unexpected `java.lang.AssertionError: Failed: Check
>> [libc] package is in the list of required packages [/bin/sh, /bin/sh,
>> /bin/sh, rpmlib(CompressedFileNames) <= 3.0.4-1,
>> rpmlib(PayloadFilesHavePrefix) <= 4.0-1] of [simplepackagetest] package`
>> error when bundling RPM package on Ubuntu; Make `getDefaultPackageArch()`
>> thread-safe
>
> Alexey Semenyuk has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to the previous content of the PR. The pull request contains two new
> commits since the last revision:
>
> - Update copyright year
> - JPackageCommand: add standard assert to check that jpackage's output
> doesn't contain the "wrong Linux package architecture" error
src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources.properties
line 63:
> 61: error.unexpected-package-property=Expected value of "{0}" property is
> [{1}]. Actual value in output package is [{2}]. Looks like the value of "{0}"
> property is hardcoded in "{3}" file in the resource directory
> 62: error.unexpected-package-property.advice=Use [{0}] pattern string instead
> of hard coded value [{1}] of {2} property in custom "{3}" file
> 63: error.unexpected-default-package-property.advice=Don''t explicitly set
> value of "{0}" property in custom "{1}" file
Why two '' in `Don''t?`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30085#discussion_r2893365729
