On Tue, 3 Feb 2026 02:52:33 GMT, Alexander Matveev <[email protected]> wrote:

>> - Version will be read from JDK's release file if not provided via 
>> `--version` for runtime installer.
>> - Added test to cover added functionality.
>> - On macOS and Windows version from JDK's release file will be normalized if 
>> it does not fit platform requirements.
>
> Alexander Matveev has updated the pull request with a new target base due to 
> a merge or a rebase. The pull request now contains eight commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8357404
>  - 8357404: jpackage should attempt to get a package version from the JDK's 
> release file if the --version option is not specified [v6]
>  - merge with upstream
>  - 8357404: jpackage should attempt to get a package version from the JDK's 
> release file if the --version option is not specified [v5]
>  - 8357404: jpackage should attempt to get a package version from the JDK's 
> release file if the --version option is not specified [v4]
>  - 8357404: jpackage should attempt to get a package version from the JDK's 
> release file if the --version option is not specified [v3]
>  - 8357404: jpackage should attempt to get a package version from the JDK's 
> release file if the --version option is not specified [v2]
>  - 8357404: jpackage should attempt to get a package version from the JDK's 
> release file if the --version option is not specified

8357404: jpackage should attempt to get a package version from the JDK's 
release file if the --version option is not specified [v7]
- Fixed all review comments.
- Version normalization will be done in all cases if version is not provided 
via command line.
- Version normalization will be done only if it is not valid platform version. 
Before we always normalized to 3 components on macOS and 4 on Windows. For 
example valid macOS version 1.0 will be normalized to 1.0.0. Now 1.0 will not 
be normalized on macOS.
- Fixed `ModulePathTest3` to use "valid" runtime bundle, since `MacBundle` is 
used on bundles from now on and perform better check, then just "Contents/Home".

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29260#issuecomment-3850543346

Reply via email to