On Sun, 25 Jan 2026 10:57:52 GMT, Eirik Bjørsnøs <[email protected]> wrote:

> Please review this comment-only PR  which updates a field comment referring 
> to `ZipFile.Source` as "native".
> 
> ZipFile has not used a native implementation since Java 8, so this comment 
> may be confusing.
> 
> The comment seems to have been introduced in 2017 as part of JDK-8185582 when 
> ZipFile was updated to use Cleaners instead of finalizers. (The use of 
> quotation marks in "native" may have meant to indicate that this is "not 
> really native", but I still find it confusing).
> 
> While visiting this comment, I also made an attempt to make the leading 
> sentence of this field comment less mysterious. 
> 
> Comment only, trivial, low risk: `noreg-trivial`

Thanks for reviewing this code comment improvement!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/29401#issuecomment-3804347459

Reply via email to