On Thu, 18 Dec 2025 16:46:26 GMT, Roger Riggs <[email protected]> wrote:

>> Refactor serialization tests to use JUnit.
>> Automated conversion for most annotations.
>> Conditional tests are refactored to use JUnit Enable/DisableIf.
>
> Roger Riggs has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Cleanup arglist and fix code style

test/jdk/java/io/Serializable/serialFilter/SerialFilterTest.java line 403:

> 401:     @MethodSource("invalidLimits")
> 402:     void testInvalidLimits(String pattern) {
> 403:         Assertions.assertThrows(IllegalArgumentException.class, () -> {

Perhaps simplifying these exception checking cases such as,


var iae = Assertions.assertThrows(IllegalArgumentException.class,
           () -> ObjectInputFilter.Config.createFilter(pattern));
System.out.printf("    success exception: %s%n", iae);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28877#discussion_r2683484242

Reply via email to