On Wed, 26 Nov 2025 16:46:41 GMT, David Beaumont <[email protected]> wrote:

>> Adds a semantic reason for failure which can be optionally interrogated by 
>> calling code.
>> Use the 'Reason.BAD_VERSION' value to trigger a different translated error 
>> message from the JImageTask.
>> 
>> I would consider moving the error message string into the Reason enum to 
>> simplify the code triggering the error and avoid message string duplication, 
>> but it's not straightforward due to the need to supply the version numbers.
>> 
>> We can use this approach to provide translated messages for all the distinct 
>> failure reasons if needed.
>
> David Beaumont has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Redo bad indentation
>  - undo blank line

I don't think any per-version maintenance is required. Both the creation and 
open version check would use `Runtime.version()`.  On creation, its written 
into the jimage file and on open its checked against the current version.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28456#issuecomment-3739123908

Reply via email to