On Wed, 24 Dec 2025 02:09:57 GMT, Jaikiran Pai <[email protected]> wrote:

>> Naoto Sato has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains three additional 
>> commits since the last revision:
>> 
>>  - Reverted bugid in the test
>>  - Merge branch 'master' into JDK-8374217-Remove-IO-from-AOTProblemList
>>  - initial commit
>
> test/jdk/java/lang/IO/IO.java line 53:
> 
>> 51: /*
>> 52:  * @test
>> 53:  * @bug 8305457 8342936 8351435 8344706 8361613 8374217
> 
> Hello Naoto, the changes look OK to me. However, the guidelines of using 
> `@bug` for tests https://openjdk.org/guide/#jtreg say:
> 
>> These bug ids refer to product bugs for which a fix is verified by this 
>> test. JBS issues that track changes to the test itself are not listed here.
> 
> So I think we shouldn't add this bug id here.

You're right. Reverted the bug ID in the test

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28967#discussion_r2658200576

Reply via email to