On Thu, 18 Dec 2025 18:01:03 GMT, Chen Liang <[email protected]> wrote:

> The bitwise manipulation code in ImageDecompressor::getU8 and getU4 utilizes 
> implicit conversion to signed int for bitwise or, making this code confusing, 
> especially when the most significant bytes are explicitly converted to 
> unsigned long long, and unsigned long long takes part in a bitwise or with 
> int. We should convert all u1 to u8/u4 before shifts to make the code easier 
> to maintain and understand.

I ran tier 1-5, only unrelated failures. Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28903#issuecomment-3684607749

Reply via email to