On Tue, 16 Dec 2025 17:47:42 GMT, Quan Anh Mai <[email protected]> wrote:
>> @PaulSandoz Thanks for your suggestion! I declared some identity constants >> in both the tests and the implementations. And added some tests to verify >> the correctness of these constants. >> >> @merykitty Now we're using a correct constant to represent the identity >> value, eliminating the dependency on incorrect literals. So I've chosen to >> keep the current coding style. I tried the style you suggested, but I feel >> the original style is more readable and maintainable. Do you think this is >> okay? >> >> Please help take another look, thank you! > > Then, please add tests to verify the correctness of these identity value > (i.e. `x + i == x`). Yeah, I have added two tests for these constants, see https://github.com/openjdk/jdk/pull/28692/changes#diff-18d929c1615a4dbad7c65daa66edc98fa1537968fa14a2b8105145d18e9eb12fR6471. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28692#discussion_r2626433209
