On Mon, 15 Dec 2025 22:50:22 GMT, Justin Lu <[email protected]> wrote:
> This PR updates a batch of _java/util_ tests from TestNG to JUnit.
> Specifically,
> - _java/util/Calendar_
> - _java/util/TimeZone_
> - _java/util/Properties_
> - _java/util/ResourceBundle_
>
>
> This change is fully automated, I did not identify any further manual changes
> required. The total number of framework based tests reported by Jtreg remain
> the same,
>
> **Calendar**
> `791 = 17 TestNG + 774 JUnit -> 0 TestNG + 791 JUnit`
>
> **TimeZone**
> `84 = 39 TestNG + 45 JUnit -> 0 TestNG + 84 JUnit`
>
> **Properties**
> `28 = 28 TestNG + 0 JUnit -> 0 TestNG + 28 JUnit`
>
> **ResourceBundle**
> `45 = 45 TestNG + 0 JUnit -> 0 TestNG + 45 JUnit`
LGTM. One suggestion not related to testng->junit effort.
test/jdk/java/util/Calendar/JapaneseLenientEraTest.java line 45:
> 43: public class JapaneseLenientEraTest {
> 44:
> 45: Object[][] names() {
Probably blame is on me, but it would make more sense to rename this method to
`lenientEra`.
-------------
PR Review: https://git.openjdk.org/jdk/pull/28836#pullrequestreview-3584588629
PR Review Comment: https://git.openjdk.org/jdk/pull/28836#discussion_r2624439179
