On Mon, 8 Dec 2025 13:21:12 GMT, Emanuel Peter <[email protected]> wrote:
>> Hamlin Li has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - remove log_warning
>> - add test cases: BoolTest::ge/gt in enc_cmove_fp_cmp_fp
>
> test/hotspot/jtreg/compiler/c2/irTests/TestConditionalMove.java line 39:
>
>> 37: * @summary Auto-vectorization enhancement to support vector conditional
>> move.
>> 38: * @library /test/lib /
>> 39: * @run driver compiler.c2.irTests.TestConditionalMove
>
> Suggestion:
>
> * @run driver ${test.main.class}
>
> Might as well do that now. Avoids wrong copy of class name, which can lead to
> wrong test being run.
Also: if you are already renaming these tests, you might move them to a better
directory as well. We want to avoid the `irTests` directory in the future, and
sort by topic instead.
Idea: put it under a `compiler/c2/cmove` directory.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28309#discussion_r2598664764
