On Wed, 26 Nov 2025 08:48:31 GMT, Jaikiran Pai <[email protected]> wrote:
>> Ana Maria Mihalceanu has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year in plugin properties.
>
> test/jdk/tools/jlink/TaskHelperTest.java line 258:
>
>> 256: } catch (IOException ex) {
>> 257: fail("Unexpected IOException");
>> 258: }
>
> Nit - it might be better to just remove this try/catch block and let any
> unexpected exception propagate (you can add a throws clause to the test
> method signature). That way if any unexpected exception is raised, the
> failure report will contain the relevant stacktrace which should help
> debugging the failure.
I followed your advice and moved the exception in the `@throws` clause.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28359#discussion_r2564239787
