On Tue, 18 Nov 2025 21:18:55 GMT, Joe Darcy <[email protected]> wrote:
>> Dhamoder Nalla has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> [AArch64] Math.log is 10% slower than StrictMath.log on aarch64
>
> test/jdk/java/lang/Math/TestLogMonotonicity.java line 29:
>
>> 27: * @run main TestLogMonotonicity
>> 28: */
>> 29: public class TestLogMonotonicity {
>
> So the test is checking for monotonicity over value that are 2X the previous
> value?
>
> That is a very weak test.
>
> In other math library regression tests we test for monotonicity on successive
> values.
Thanks @jddarcy, Updated the existing LogTests.java with similar monotonicity
test in Log1pTests.java.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28306#discussion_r2562205428
