On Tue, 25 Nov 2025 16:51:57 GMT, Alan Bateman <[email protected]> wrote:

>> src/java.base/share/classes/java/util/concurrent/ThreadLocalRandom.java line 
>> 503:
>> 
>>> 501: 
>>> 502:     /**
>>> 503:      * {@inheritDoc}
>> 
>> Inheriting the doc from `Random` doesn't seem correct in this case.
>
> Right, this will require attention. You kinda want `{@inheritDoc 
> java.util.random.RandomGenerator}` but without overriding the method 
> description then it won't appear in the Method Summary. The nextGaussian 
> method defined by j.u.Random and j.u.random.RandomGenrator will be listed in 
> the "Method declared by ..." section of course. 
> 
> In addition, Random's implSpec has the polar method whereas RandomGenrator's 
> implSpec is ziggurat algorithm. So I think TLR.nextGaussian will need to copy 
> from text RandomSupport.computeNextGaussian to get the right comment.

In passing, I see there are several empty "Implementation Note:" in the TLR 
docs. It seems to be `@implNote {@inheritDoc}` when there isn't anything to 
inherit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28483#discussion_r2560764537

Reply via email to