On Tue, 25 Nov 2025 03:58:17 GMT, Alexander Matveev <[email protected]>
wrote:
> Added following tests:
> - Verify mac app store PKG doesn't have scripts (added to
> `PkgScriptsTest.java`).
> - `--launcher-as-service` ignored for mac app store PKG (added to
> `ServiceTest.java`).
> - `--launcher-as-service` for additional launcher ignored for mac app store
> PKG (added to `ServiceTest.java`).
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java line 815:
> 813: final boolean withServices = !cmd.isRuntime()
> 814: &&
> !LauncherAsServiceVerifier.getLaunchersAsServices(cmd).isEmpty()
> 815: && !cmd.hasArgument("--mac-app-store");
I suggest updating `LauncherAsServiceVerifier.getLaunchersAsServices()` instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28487#discussion_r2560643219