On Tue, 25 Nov 2025 12:47:38 GMT, Viktor Klang <[email protected]> wrote:

>> Adds the patch by @DougLea
>
> Viktor Klang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Changes after code review

test/jdk/java/util/concurrent/BlockingQueue/MissedPoll.java line 52:

> 50:                     return super.onAdvance(phase, registeredParties);
> 51:                 }
> 52:             };

@DougLea I decided to mod the phaser to have the clearing of the queue as a 
part of the advancement of the phaser

test/jdk/java/util/concurrent/BlockingQueue/MissedPoll.java line 72:

> 70:                 Integer res;
> 71:                 if ((res = future.get()) != 0)
> 72:                     throw new AssertionError("Expected 0 but got " + res);

@AlanBateman I added this

test/jdk/java/util/concurrent/BlockingQueue/MissedPoll.java line 76:

> 74:         }
> 75:         if (!q.isEmpty())
> 76:             throw new AssertionError("Queue is not empty: " + q);

@DougLea Added this

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28479#discussion_r2559870829
PR Review Comment: https://git.openjdk.org/jdk/pull/28479#discussion_r2559868675
PR Review Comment: https://git.openjdk.org/jdk/pull/28479#discussion_r2559869325

Reply via email to