On Tue, 25 Nov 2025 02:38:52 GMT, Fei Yang <[email protected]> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix is_unordered
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 2141:
>
>> 2139: case BoolTest::gt:
>> 2140: cmov_fp_cmp_fp_gt(op1, op2, dst, src, cmp_single, cmov_single);
>> 2141: log_warning(jit)("Float/Double BoolTest::gt path is not tested
>> well, please report the test case!");
>
> My local tests show this does happen. Try this:
> `$ make test
> TEST="./test/jdk/javax/sound/midi/Gervill/SoftFilter/TestProcessAudio.java"
> TEST_VM_OPTS="-XX:-TieredCompilation"`
>
> I think this could be a good reference if you want to add some extra tests
> for the two cases here.
Thanks, I'll check it later.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28309#discussion_r2559281739
