On Wed, 12 Nov 2025 19:48:54 GMT, Paul Sandoz <[email protected]> wrote:

> > > > Some quick comments.
> > > > We should be consistent in the naming, and rename `Halfloat*` to 
> > > > `Float16*`.
> > > 
> > > 
> > > I concur, especially since there are multiple 16-bit floating-point 
> > > formats in use including the IEEE 754 float16 as well as bfloat16.
> > 
> > 
> > There are nomenclature issues that I am facing. Currently, all the Float16 
> > concrete classes use the Halffloat prefix i.e., Halffloat64Vector, 
> > Halffloat128Vector; converting these to Float16 looks a little confusing, 
> > i.e., Float1664Vector, Float16128Vector, etc Kindly suggest a better name 
> > to represent these classes.
> 
> Maybe we move the shape to the end e.g., `Float16Vector128`, `IntVector128`, 
> `IntVectorMax`?

This looks good, since all these are concrete vector classes not exposed to 
users.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28002#issuecomment-3526723445

Reply via email to