On Sat, 1 Nov 2025 02:51:24 GMT, Alexey Semenyuk <[email protected]> wrote:

>> - Fix MacPackagingPipeline.
>> - Fix AppImageSigner: this is the follow-up for MacPackagingPipeline fix. 
>> Without fixing AppImageSigner AppImagePackageTest.testEmpty test fails. It 
>> happened that the test passed because jpackage wrongly created the plist 
>> file for the embedded runtime in the case of the predefined app image. The 
>> test passed because of the bug in jpackage fixed in this PR.
>> - Add test cases for predefined app image packaging to the 
>> CustomInfoPListTest test. They had been failing before MacPackagingPipeline 
>> was fixed.
>> 
>> Supplementary changes:
>>  - Get rid of duplicated `createInputRuntimeImage()` and 
>> `createRuntimeBundle()` functions.
>>  - Improve `MacHelper.writeFaPListFragment()` to work with a predefined app 
>> image.
>>  - Add optional tracing to the packaging pipeline (turned off by default, 
>> must edit static fields to enable in custom builds).
>>  - PListReader: add find methods that return an Optional instead of throwing 
>> an exception when the requested key is not found; update unit tests.
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Document Slot class

Looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28089#pullrequestreview-3406797378

Reply via email to