On Tue, 28 Oct 2025 15:05:14 GMT, Matthias Baesken <[email protected]> wrote:

> There are some ancient Windows versions still handled in GetJavaProperties :
> 
> https://github.com/openjdk/jdk/blob/master/src/java.base/windows/native/libjava/java_props_md.c#L456
> 
> We compile currently with Windows 8+ settings :
> 
> 
> # _WIN32_WINNT=0x0602 means access APIs for Windows 8 and above. See
> # 
> https://docs.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-170
> ALWAYS_DEFINES="-DWIN32_LEAN_AND_MEAN -D_WIN32_WINNT=0x0602 \
> 
> 
> So everything older than Windows 8 could most likely be removed.

Looks good.

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28022#pullrequestreview-3404430500

Reply via email to