On Wed, 29 Oct 2025 16:08:49 GMT, Chen Liang <[email protected]> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Remove requires vm.debug
>
> test/jdk/java/foreign/sharedclosejfr/TestSharedCloseJFR.java line 30:
> 
>> 28:  * @requires vm.flavor != "zero"
>> 29:  * @requires vm.debug
>> 30:  * @requires vm.hasJFR
> 
> You can use & to require multiple conditions at once in one directive.

I prefer the readability of the separate requires tags. The `vm.debug` 
requirement can be removed though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27919#discussion_r2474403743

Reply via email to