On Sat, 11 Oct 2025 09:09:07 GMT, Tagir F. Valeev <[email protected]> wrote:
>> Vladimir Yaroslavskiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8266431: Dual-Pivot Quicksort improvements >> >> * Moved Radix sort out from sorting > > src/java.base/share/classes/java/util/DualPivotQuicksort.java line 152: > >> 150: @ForceInline >> 151: @IntrinsicCandidate >> 152: private static <T> void sort(Class<?> elemType, T a, long offset, > > Why do we need this method? Offset and elemType are not used here. Probably > it could be inlined? These methods sort() and partition() were introduced in PR https://github.com/openjdk/jdk/pull/14227 where intrinsics for sorting and partitioning based on AVX512 instructions were added. The signature of these methods are in sync with native implementations from linux/native/libsimdsort package. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27411#discussion_r2453292847
