On Tue, 30 Sep 2025 06:01:40 GMT, Jaikiran Pai <[email protected]> wrote:
>> Kieran Farrell has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> missing semicolon
>
> src/java.base/share/classes/java/util/UUID.java line 208:
>
>> 206: * @since 26
>> 207: * */
>> 208: public static UUID epochMillis(long timestamp) {
>
> Now that we have settled on which API to expose, would it be better to rename
> this new method to `fromEpochMillis(...)`? This class already has a
> `fromString(...)` API, so `fromEpochMillis(...)` would fit in with that style
> and would be a bit more precise too, I think.
The rest of the changes in the PR looks fine to me. Before reviewing the CSR, I
think we should come to an agreement on the method naming.
I prefer `fromEpochMillis(...)` instead of the current `epochMillis(...)`.
@RogerRiggs, @AlanBateman which one of these method names do you suggest we
proceed with?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25303#discussion_r2452727232
