On Mon, 20 Oct 2025 13:04:15 GMT, Weibing Xiao <[email protected]> wrote:

>> [webrev.zip](https://github.com/user-attachments/files/22605072/webrev.zip)
>> NPE thrown from SASL GSSAPI impl when TLS is used with QOP auth-int against 
>> Active Directory.
>> 
>> When the exception is triggered, LDAP Connection will do "clean-up" 
>> operation and output stream get flushed and closed the context while 
>> GssKrb5Client is still wrapping the message, and tried to send the abandoned 
>> info to the client at line  
>> https://github.com/openjdk/jdk/blob/master/src/jdk.security.jgss/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Base.java#L140.
>>  That's the reason to throw NPE.
>> 
>> The change is going to close socket and output stream in LdapClient.java. It 
>> would allow SASL client code to send the abandoned request to client; then 
>> dispose GSS context. This will avoid NPE to thrown at line 140 of 
>> GssKrb5Base.java.
>> 
>> No test file is attached for this MR since it needs Sasl LDAP server with 
>> security setup. Attached the updated webrev for the reference.
>
> Weibing Xiao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add new method to handle connection cleaning

Updated the code accordingly.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26566#issuecomment-3426517818

Reply via email to