On Wed, 15 Oct 2025 15:56:46 GMT, fabioromano1 <[email protected]> wrote:

>> An implementation of `BigDecimal.nthRoot(int, MathContext)`.
>
> fabioromano1 has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Comment for error analysis

Two general comments:

* For the specification, I suggest structuring it so that the "happy cases" 
were the error is less than one half ulp are given toward the beginning with 
the large bounds given later.
* This PR will need test development too of course as it get closer to getting 
pushed.

If the various half-way rounding mode could be made to round correctly at 
reasonable cost and complexity, I think that would be a preferable situation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27148#issuecomment-3420569240

Reply via email to