On Tue, 23 Sep 2025 21:58:56 GMT, Justin Lu <[email protected]> wrote:
> Please review this PR which converts all the _TestNG_ based tests under > jdk_text to use _JUnit_. > > The changes are done in the following order, > > - > https://github.com/openjdk/jdk/commit/a7840e72269202dfca99d5ce5109bd4f7af0f578: > Conversions automated via > [script](https://github.com/lahodaj/netbeans/tree/19515c3e2dbc07d977ca227d933197f856121ae5/java/java.openjdk.project/junit-convert). > - > https://github.com/openjdk/jdk/commit/2466c5ee970965e57978d8b55b5b7dcad6c2aa6c: > Updating to default recommended visibility of test methods + data providers. > Cleaning up imports. > - > https://github.com/openjdk/jdk/commit/27c439804db61e26d48d7239fd28c99258cb4a9f: > Copyright years updated. LGTM test/jdk/java/text/Format/CompactNumberFormat/TestUExtensionOverride.java line 36: > 34: import org.junit.jupiter.params.ParameterizedTest; > 35: import org.junit.jupiter.params.provider.MethodSource; > 36: Probably done with the script, but it's interesting it would put junit impots before java's. ------------- Marked as reviewed by naoto (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/27460#pullrequestreview-3264097251 PR Review Comment: https://git.openjdk.org/jdk/pull/27460#discussion_r2376648699
