On Wed, 8 Oct 2025 23:39:48 GMT, Alexander Matveev <[email protected]> wrote:

>> - Removed pre- and post- installation PKG scripts.
>> - This code is not needed and PKG should create destination folder and set 
>> correct permissions.
>> - If for some reason it is not happens, permissions issues should be fixed 
>> when jpackage prepares application bundle. PKG should keep all permissions 
>> unchanged when packaging and installing bundle.
>> - Users will have ability to provide pre- and post- installation PKG scripts 
>> if needed.
>> - `INSTALL_LOCATION` and `APP_LOCATION` substitution is removed, since `$2` 
>> argument in scripts is same as `INSTALL_LOCATION`.
>> - I think code in these scripts are some legacy leftovers.
>> - Added test to test that pre- and post-scripts are no longer exist and can 
>> be added via `--resource-dir`.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8356047: [macos] jpackage produces confusing post- and pre- installation 
> PKG scripts [v10]

8356047: [macos] jpackage produces confusing post- and pre- installation PKG 
scripts [v11]
- Moved log message for no resource to `ShellScriptResource`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25510#issuecomment-3383682422

Reply via email to