On Mon, 6 Oct 2025 10:13:21 GMT, Mahendra Chhipa <[email protected]> wrote:

>> Update SimpleHttpServer class to use SimpleFileServer.
>
> Mahendra Chhipa has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Added jdk.test.lib.net.URIBuilder import.

test/jaxp/javax/xml/jaxp/unittest/catalog/CatalogFileInputTest.java line 104:

> 102:         httpserver.start();
> 103:         remoteFilePath = "http:" + 
> URIBuilder.newBuilder().host(httpserver.getAddress().getAddress()).
> 104:                 
> port(httpserver.getAddress().getPort()).build().toString() + 
> REMOTE_FILE_LOCATION;

Suggestion:

        remoteFilePath = URIBuilder.newBuilder()
            .scheme("http")
            .host(httpserver.getAddress().getAddress())
           .port(httpserver.getAddress().getPort())
           .build().toString() + REMOTE_FILE_LOCATION;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27608#discussion_r2406311037

Reply via email to