On Mon, 15 Sep 2025 15:17:29 GMT, Pavel Rappo <[email protected]> wrote:
> Please review this documentation-only change, which I believe does **NOT** > require CSR. > > The change touches java.time.** classes that I happen to have been using a > lot recently. While the diff is pretty self-describing, here's the summary of > what I did: > > * used a comma separator for some big integer values, to improve readability; > * fixed a few typos and grammar. > > While I'm open to discuss the change, I also have some questions. Note: I'm > not attempting to address those questions in this PR. > > * What's the significance of the second argument in > Duration.between(Temporal, Temporal) being exclusive? For example, would the > result of the following call be different if the second argument was > inclusive? > > Duration.between(Instant.ofEpochSecond(1), Instant.ofEpochSecond(2)) > > Are there any cases here where that distinction matters? > > * In many cases, the following phrase is used throughout documentation: > > > positive or negative > > While the intent is clearly to stress the directed nature of values, > shouldn't we -- for completeness -- also mention zero where applicable? > > * What's the significance of title-case for Java Time-Scale? FWIW, the > documentation also uses "Java time-scale". This pull request has now been integrated. Changeset: e44ef0c3 Author: Pavel Rappo <[email protected]> URL: https://git.openjdk.org/jdk/commit/e44ef0c32b3c2fcd0a6293838d9185b6d0719219 Stats: 36 lines in 8 files changed: 0 ins; 0 del; 36 mod 8367704: Fix minor documentation issues in java.time.** Reviewed-by: naoto, rriggs ------------- PR: https://git.openjdk.org/jdk/pull/27296
