On Tue, 14 Oct 2025 13:10:22 GMT, Viktor Klang <[email protected]> wrote:
>> Addresses the regression regarding pool assistance and includes a regression
>> test for `CompletableFuture::get()`, `CompletableFuture::get(timeout,
>> unit)`, and `CompletableFuture::join()`
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improving the name of the regtest
Marked as reviewed by alanb (Reviewer).
test/jdk/java/util/concurrent/tck/CompletableFutureTest.java line 5138:
> 5136: }}
> 5137:
> 5138: public void testOnlyAssistsIfInTheSamePool() throws Exception{
The API and implementations speak of helping rather than assisting so if you
are editing then maybe rename the method.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27800#pullrequestreview-3339843773
PR Review Comment: https://git.openjdk.org/jdk/pull/27800#discussion_r2432170451
