On Wed, 8 Oct 2025 14:49:07 GMT, Lance Andersen <[email protected]> wrote:
> This PR adds support for the upcoming JDBC 4.5 MR which provides the
> following updates to the JDBC specification:
>
> - Deprecate SQLPermission for removal
> - Enhance the Blob/Clob/Array/SQLXML/NClob interfaces to extend/support
> AutoClosable
> - Add the SQL types DECFLOAT, JSON to Types.Java and JDBCType.java
> - Add the quoted identifier methods that **were added previously to the
> Statement interface in JDK 9** to the Connection interface
> - It is the exact same verbiage & default methods used when these methods
> were added to the Statement interface
> - Clarify the Timestamp::hashCode method which incorrectly indicates that
> nanos are not used when calculating the hash
>
> Tiers 1-3 have been run
src/java.sql/share/classes/java/sql/Connection.java line 1897:
> 1895: * underlying datasource.
> 1896: * @param identifier a SQL identifier
> 1897: * @return true if a simple SQL identifier, false otherwise
Suggestion:
* @return true if a simple SQL identifier, false otherwise
src/java.sql/share/classes/java/sql/DriverPropertyInfo.java line 33:
> 31: * <p>Driver properties for making a connection. The
> 32: * {@code DriverPropertyInfo} class is of interest only to advanced
> programmers.
> 33: * The method {@linkplain Driver#getPropertyInfo(String, Properties)} may
> be used
Suggestion:
* The method {@link Driver#getPropertyInfo(String, Properties)} may be used
src/java.sql/share/classes/java/sql/SQLPermission.java line 32:
> 30:
> 31: /**
> 32: *This class was only useful in conjunction with the {@link
> java.lang.SecurityManager},
Suggestion:
* This class was only useful in conjunction with the {@link
java.lang.SecurityManager},
src/java.sql/share/classes/java/sql/SQLXML.java line 180:
> 178: * writing APIs are called: setBinaryStream(), setCharacterStream(),
> setResult(), and setString().
> 179: * Implementations may also change the state to not readable when this
> occurs.
> 180: *<p>
Suggestion:
* <p>
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2414490949
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2414477211
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2414458104
PR Review Comment: https://git.openjdk.org/jdk/pull/27693#discussion_r2414460512
