On Fri, 3 Oct 2025 17:47:08 GMT, Daniel Fuchs <[email protected]> wrote:

>> Mahendra Chhipa has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Implemented review comments.
>
> test/jaxp/javax/xml/jaxp/unittest/catalog/CatalogFileInputTest.java line 103:
> 
>> 101:         httpserver.start();
>> 102:         remoteFilePath = "http:" + 
>> jdk.test.lib.net.URIBuilder.newBuilder().host(httpserver.getAddress().getAddress()).
>> 103:                 
>> port(httpserver.getAddress().getPort()).build().toString() + 
>> REMOTE_FILE_LOCATION;
> 
> Suggestion:
> 
>         remoteFilePath = jdk.test.lib.net.URIBuilder.newBuilder()
>             .scheme("http")
>             .host(httpserver.getAddress().getAddress())
>             .port(httpserver.getAddress().getPort())
>             .build().toString() + REMOTE_FILE_LOCATION;

Is there another URIBuilder that prevents importing 
`jdk.test.lib.net.URIBuilder`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27608#discussion_r2402812037

Reply via email to