On Wed, 1 Oct 2025 16:06:45 GMT, Joe Darcy <[email protected]> wrote:
>> A few more small cleanups to Float16 and its tests.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java line
756:
> 754: public static boolean isInfinite(Float16 f16) {
> 755: return ((float16ToRawShortBits(f16) ^
> float16ToRawShortBits(POSITIVE_INFINITY)) &
> 756: (EXP_BIT_MASK | SIGNIF_BIT_MASK)) == 0;
IMHO, `isNan()` and `isInfinite()` should look almost identical, except for the
significand bits.
Maybe for another time.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27587#discussion_r2395223913
