On Wed, 27 Aug 2025 19:18:17 GMT, Chen Liang <[email protected]> wrote:

>> As another step toward the removal of the old generics infrastructure, I 
>> propose to remove the usages of generic parsing utilities and use the 
>> facilities provided by BytecodeDescriptor, already used by 
>> MethodType.fromDescriptorString. This also prevents extra validation cost in 
>> use sites to defend against generic types.
>> 
>> In this patch, BytecodeDescriptor and Wrapper see minor updates, mainly for 
>> better exception messages - previously, an unparseable char in the 
>> descriptor string just reports that char, and now the whole descriptor 
>> string is reported.
>> 
>> These behaviors are already covered by the tests added in JDK-8350704 #23788.
>> 
>> Testing: reflect/annotation/Class, running tier 1+2
>
> Chen Liang has updated the pull request with a new target base due to a merge 
> or a rebase. The incremental webrev excludes the unrelated changes brought in 
> by the merge/rebase. The pull request contains four additional commits since 
> the last revision:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 
> fix/generic-desc-parse
>  - Roll back wrapper, test for BytecodeDescriptor
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 
> fix/generic-desc-parse
>  - 8356022: Migrate descriptor parsing from generics to BytecodeDescriptor

Marked as reviewed by rriggs (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24978#pullrequestreview-3273946569

Reply via email to