On Fri, 29 Aug 2025 18:00:25 GMT, Justin Lu <j...@openjdk.org> wrote:
> This PR addresses a JCK test failure related to `DecimalFormatSymbols` > de-serialization. While the current public API of DFS disallows a null > locale, it was possible to set in the past. Thus, the > `loadNumberData(locale)` call currently throws NPE when locale is null in the > stream. The call should be guarded with a null check, such that if locale is > null, then `lenientMinusSigns` defaults to `minusSignText`. > > Defaulting the locale field when `null` to Locale.ROOT is also a reasonable > solution, but I think that the current one is preferable as a user would not > expect locale data related logic to occur if locale is `null`. Have you considered adding a unit or regression test to exercise DecimalFormatSymbols serialization? I assume this issue slipped through and was caught else because the jdk repo doesn't have any tests for this. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27008#issuecomment-3239003577
