java.lang.invoke has a few Holder classes in DirectMethodHandle, 
DelegatingMethodHandle, Invokers, and LambdaForm.

Currently, the comments simply refer to "Placeholder for xxx generated 
ahead-of-time".

However, they carry executed bytecode and show up in flame graphs. The current 
comments are definitely not sufficient for their details and purposes.

To address these shortcomings, I improved the comments on the Holder classes 
and GenerateJLIClassesHelper to briefly describe the generation process. In 
addition, I improved the comments on BoundMethodHandle to provide a more 
efficient overview.

-------------

Commit messages:
 - 8365428: Unclear comments on java.lang.invoke Holder classes

Changes: https://git.openjdk.org/jdk/pull/27010/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=27010&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8365428
  Stats: 128 lines in 7 files changed: 93 ins; 8 del; 27 mod
  Patch: https://git.openjdk.org/jdk/pull/27010.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/27010/head:pull/27010

PR: https://git.openjdk.org/jdk/pull/27010

Reply via email to