On Thu, 28 Aug 2025 23:36:25 GMT, Chen Liang <li...@openjdk.org> wrote:
>> In the `class` file format, a lot of the values are `u1` or `u2`; the
>> Class-File API consistently model them with `int`. However, the API does
>> not, in general, validate that int values passed to the factory methods are
>> not out of the bounds as defined in the class file format. This patch
>> proposes to add such validation for factory methods accepting such more
>> narrow data, prepared by examining all `int`-accepting methods in the
>> Class-File API.
>>
>> I expect this to have a small compatibility impact - besides the -1 for the
>> minor version, there is no other places where most significant bits are ever
>> meaningful, and I special cased it and consistently fail fast for all other
>> OOB values, which always mean programmer errors.
>>
>> A CSR will be created soon as well.
>
> Chen Liang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed one link
src/java.base/share/classes/java/lang/classfile/attribute/ModuleExportInfo.java
line 136:
> 134: * @param exportsTo the modules to which this package is exported,
> or empty
> 135: * if this is an unqualified export
> 136: * @throws IllegalArgumentException if {@code exportFlags} is not
> i{@link
nit typo
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26201#discussion_r2309522639
