On Tue, 8 Jul 2025 20:28:23 GMT, Chen Liang <li...@openjdk.org> wrote:
>> In the `class` file format, a lot of the values are `u1` or `u2`; the >> Class-File API consistently model them with `int`. However, the API does >> not, in general, validate that int values passed to the factory methods are >> not out of the bounds as defined in the class file format. This patch >> proposes to add such validation for factory methods accepting such more >> narrow data, prepared by examining all `int`-accepting methods in the >> Class-File API. >> >> I expect this to have a small compatibility impact - besides the -1 for the >> minor version, there is no other places where most significant bits are ever >> meaningful, and I special cased it and consistently fail fast for all other >> OOB values, which always mean programmer errors. >> >> A CSR will be created soon as well. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Fix style Nice summary fix of the validation. ------------- Marked as reviewed by asotona (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26201#pullrequestreview-3000909266
