On Fri, 29 Aug 2025 05:52:41 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> @RogerRiggs Good catch! Fixed. > > That doesn't seem right to me. If we massively overflow to get a value > > -JAVA_CLASSNAME_MAX_LEN but < 0 then the subtraction becomes addition and we > get a small positive value. > > Really ModifiedUtf.utflen should be defined to return long so the caller can > more easily deal with overflow. Giant strings are a PITA. Hi @dholmes-ora , thanks for pointing this out — giant strings are indeed a PITA. I’ll revert to the previous version, as it looks like the safer approach. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26802#discussion_r2309289849
