On Mon, 21 Jul 2025 13:00:03 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Rename `NoReplacement` suffix to `OrThrow` >> - Simplify `encodeWithEncoder` and trim long lines > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 328: > >> 326: * @throws CharacterCodingException for malformed or unmappable >> bytes >> 327: */ >> 328: String uncheckedNewString(byte[] bytes, Charset cs) throws >> CharacterCodingException; > > The docs should mention these two details: > 1. This method does not replace upon malformed data but fails > 2. This method does not copy the byte array for validation (can add to the > warning) Confirmed with @liach that his remarks are addressed – resolving this conversation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26413#discussion_r2308371942
