On Mon, 25 Aug 2025 13:19:29 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this trivial change to the
> `ModuleDescriptor.packages()` method's specification?
>
> The change here clarifies that this method returns all packages that belong
> to the module and not just those that are exported or open. This
> clarification should help avoid any confusion that may have been caused by
> the second paragraph in that method's specification which talks about
> exported and open packages.
>
> This updated specification matches the existing implementation of this method.
>
> I believe this will require a CSR, which I'll create shortly.
Hi Jai, now the term "set of the packages" is gone, but it appears twice in the
next paragraph and in the return tag. Can we have something like this that
eliminates those phrases:
/**
* {@return the possibly-empty unmodifiable set of all packages in the
module}
*
* <p> The set of all packages includes all exported and open packages, as
well
* as the packages of any service providers, and the package for the main
* class. </p>
*/
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26928#issuecomment-3220283205
