On Thu, 14 Aug 2025 10:34:59 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of these change which removes the outdated use of > `jdk.internal.javac.ParticipatesInPreview` and the qualified export of > `jdk.internal.javac` package? This addresses > https://bugs.openjdk.org/browse/JDK-8365533. > > These qualified exports in `java.base` were added in > https://bugs.openjdk.org/browse/JDK-8308753 when ClassFile API was in > preview. Starting Java 24, ClassFile API is now a part of Java SE. These > affected modules don't use any other preview feature, so there's no longer a > need to export the `jdk.internal.javac` package to these modules. > > tier1, tier2 and tier3 testing of this change completed without any related > failures. Looks right to me. However since your changed lines is directly by the java.desktop changed line, there's a conflict and you must resolve it. In addition, `PreviewFeature.Feature` enum has a few obsolete entries - they should be kept until the preview feature is not in the minimum boot JDK. Now the boot JDK is min 24, and a few of the features are already permanent in 24. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26776#pullrequestreview-3122788756 PR Comment: https://git.openjdk.org/jdk/pull/26776#issuecomment-3190566237
