On Thu, 14 Aug 2025 13:35:50 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
> - Remove AppImageDesc class. It was supposed to bind an AppImageLayout
> instance with a root directory, but since AppImageLayout has
> `rootDirectory()` method it is redundant.
> - Remove redundant `Package.packageLayout()` and
> `Package.asPackageApplicationLayout()` methods from the model,
> - Add tests for PackagingPipeline class.
> - Move JUnitAdapter.java from "/test/jdk/tools/jpackage/helpers-test" to
> "/test/jdk/tools/jpackage/junit/tools" directory, support running
> platform-specific JUnit tests.
> - Enhance AppImageLayout class, add unit tests for derived
> MacApplicationLayout and LinuxApplicationLayout classes.
> - Add tests for BuildEnv class.
Looks good. I do not have better alternatives for title. Lets keep it as is.
Also, make sure to run macOS signing tests. I left minor comment.
test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/PackagingPipelineTest.java
line 189:
> 187:
> 188: assertEquals(expected, actual);
> 189:
> System.out.println(String.format("testCreatePackage:\n---\n%s\n---", actual));
Looks like debug `println`.
test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/PackagingPipelineTest.java
line 365:
> 363: final var actual =
> Files.readString(outputDir.resolve(pkg.packageFileNameWithSuffix()));
> 364: assertEquals(expected, actual);
> 365: System.out.println(String.format("%s:\n---\n%s\n---",
Same as above.
test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/PackagingPipelineTest.java
line 588:
> 586:
> 587: assertEquals(expected, actual);
> 588: System.out.println(String.format("%s:\n---\n%s\n---",
> logMsgHeader, actual));
Same as above.
-------------
PR Review: https://git.openjdk.org/jdk/pull/26778#pullrequestreview-3122496975
PR Review Comment: https://git.openjdk.org/jdk/pull/26778#discussion_r2277992965
PR Review Comment: https://git.openjdk.org/jdk/pull/26778#discussion_r2277999124
PR Review Comment: https://git.openjdk.org/jdk/pull/26778#discussion_r2278004848
