On Mon, 11 Aug 2025 14:11:37 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> Would you run specific tiers in those platforms? Just hotspot compiler? Or
>> individual tests such as `ConvF2HFIdealizationTests` and
>> `TestFloat16ScalarOperations`?
>
> Honestly, I don't know, I'd have to do the research myself. Probably focusing
> on the Float16 tests would be good enough. No other test would really use
> Float16, so running anything else would not be that useful probably.
I've done some testing on x86_64 and aarch64 and the tests pass.
I also made sure that the test output demonstrated execution of the expected IR
rule as per the requirements of each platform.
## `c7gn.2xlarge` Graviton3
==============================
Test summary
==============================
TEST TOTAL PASS FAIL ERROR
SKIP
jtreg:test/hotspot/jtreg/compiler/c2/irTests/ConvF2HFIdealizationTests.java
1 1 0 0
0
jtreg:test/hotspot/jtreg/compiler/c2/irTests/TestFloat16ScalarOperations.java
1 1 0 0
0
jtreg:test/hotspot/jtreg/compiler/loopopts/superword/TestCompatibleUseDefTypeSize.java
1 1 0 0
0
==============================
TEST SUCCESS
$ tail ConvF2HFIdealizationTests.jtr
Messages from Test VM
---------------------
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in test1: None of the
feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
----------System.err:(3/35)----------
JavaTest Message: Test complete.
result: Passed. Execution successful
test result: Passed. Execution successful
$ tail TestFloat16ScalarOperations.jtr
Messages from Test VM
---------------------
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testDivByPOT: None
of the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh,
true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testMulByTWO: None
of the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh,
true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testInexactFP16ConstantPatterns: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testSNaNFP16ConstantPatterns: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testQNaNFP16ConstantPatterns: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testExactFP16ConstantPatterns: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testRandomFP16ConstantPatternSet1: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testRandomFP16ConstantPatternSet2: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testRounding1:
None of the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true,
zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testRounding2:
None of the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true,
zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testMax: None of
the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testAddConstantFolding: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testDivConstantFolding: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testMin: None of
the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testMinConstantFolding: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testEliminateIntermediateHF2S: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testDivByOne: None
of the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh,
true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testFMAConstantFolding: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testMaxConstantFolding: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testMul: None of
the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testconvF2HFAndS2HF: Feature constraint not met (applyIfCPUFeature):
avx512_fp16, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testDiv: None of
the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testSqrtConstantFolding: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testSqrt: None of
the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testMulConstantFolding: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testFma: None of
the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testAdd1: None of
the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testAdd2: None of
the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in
testSubConstantFolding: None of the feature constraints met
(applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
[IREncodingPrinter] Disabling IR matching for rule 1 of 2 in testSub: None of
the feature constraints met (applyIfCPUFeatureOr): avx512_fp16, true, zfh, true
----------System.err:(3/35)----------
JavaTest Message: Test complete.
result: Passed. Execution successful
test result: Passed. Execution successful
## `c7i.xlarge` Intel(R) Xeon(R) Platinum 8488C (saphire rapids):
==============================
Test summary
==============================
TEST TOTAL PASS FAIL ERROR
SKIP
jtreg:test/hotspot/jtreg/compiler/c2/irTests/ConvF2HFIdealizationTests.java
1 1 0 0
0
jtreg:test/hotspot/jtreg/compiler/c2/irTests/TestFloat16ScalarOperations.java
1 1 0 0
0
jtreg:test/hotspot/jtreg/compiler/loopopts/superword/TestCompatibleUseDefTypeSize.java
1 1 0 0
0
==============================
TEST SUCCESS
$ tail ConvF2HFIdealizationTests.jtr
Messages from Test VM
---------------------
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in test1: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
----------System.err:(3/35)----------
JavaTest Message: Test complete.
result: Passed. Execution successful
test result: Passed. Execution successful
$ tail TestFloat16ScalarOperations.jtr
Messages from Test VM
---------------------
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testDivByPOT: Not
all feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp,
true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testMulByTWO: Not
all feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp,
true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testInexactFP16ConstantPatterns: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testSNaNFP16ConstantPatterns: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testQNaNFP16ConstantPatterns: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testExactFP16ConstantPatterns: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testRandomFP16ConstantPatternSet1: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testRandomFP16ConstantPatternSet2: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testRounding1: Not
all feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp,
true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testRounding2: Not
all feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp,
true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testMax: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testAddConstantFolding: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testDivConstantFolding: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testMin: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testMinConstantFolding: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testEliminateIntermediateHF2S: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testDivByOne: Not
all feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp,
true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testFMAConstantFolding: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testMaxConstantFolding: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testMul: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testconvF2HFAndS2HF: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testDiv: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testSqrtConstantFolding: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testSqrt: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testMulConstantFolding: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testFma: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testAdd1: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testAdd2: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in
testSubConstantFolding: Not all feature constraints are met
(applyIfCPUFeatureAnd): fphp, true, asimdhp, true
[IREncodingPrinter] Disabling IR matching for rule 2 of 2 in testSub: Not all
feature constraints are met (applyIfCPUFeatureAnd): fphp, true, asimdhp, true
----------System.err:(3/35)----------
JavaTest Message: Test complete.
result: Passed. Execution successful
test result: Passed. Execution successful
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26457#discussion_r2268546321
