On Mon, 11 Aug 2025 21:03:36 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> - Support a new "app-dir" value of `win-shortcut`, `win-menu`, and 
>> `linux-shortcut` properties in additional launcher property files.
>> - Support an optional value of `--win-shortcut`, `--win-menu`, and 
>> `--linux-shortcut` CLI options. The valid value is "app-dir".
>> 
>> If a value of any property/CLI option from the above list is set to 
>> "app-dir", the startup directory of the corresponding shortcut will be set 
>> to the "app" subdirectory of the installation directory.
>> 
>> If a CLI option from the above list doesn't have a value, the startup 
>> directory of the corresponding shortcut for the main launcher will be set to 
>> the installation directory on Windows and will not be set on Linux. This is 
>> the existing behavior; it has not changed.
>> 
>> If a value of a property from the above list evaluates to `true`, the 
>> startup directory of the corresponding shortcut for the additional launcher 
>> will be set to the installation directory on Windows and will not be set on 
>> Linux. This is the existing behavior; it has not changed.
>> 
>> Added test cases to AddLShortcut test implicitly.
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Arguments, LinuxHelper: bugfix; AddLShortcutTest: better test coverage

Looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26707#pullrequestreview-3107873128

Reply via email to