On Thu, 7 Aug 2025 08:29:12 GMT, Francesco Andreuzzi <d...@openjdk.org> wrote:
>> Clean up some stale comment references. Trivial changes. > > src/hotspot/os/linux/os_linux.cpp line 4876: > >> 4874: // flag set. If we don't set it, then careless 3rd party native code >> 4875: // might fork and exec without closing all appropriate file >> descriptors >> 4876: // , and this in turn might: > > Shouldn't the comma go to the previous line? @fandreuz Thanks for your comment! You're right to point this out — I am not sure about the best placement either. I noticed that some other parts of the codebase use the same style (with the comma at the beginning of the line), so I followed that pattern here. That said, I'm happy to adjust it if needed. Let's leave it to @kevinjwalls to make the final call. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26667#discussion_r2259827846
