On Tue, 5 Aug 2025 17:48:59 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Change `BasicFileAttributes` for Windows such that for a directory junction
>> `isOther` returns `true` but all other `is*` methods return `false`. Without
>> this change, `isDirectory` also returns `true`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8364277: 1) Add and use package scope isDirectoryJunction(); 2) Remove
> explicit delete of junction from test
test/lib/jdk/test/lib/util/FileUtils.java line 457:
> 455: // Create a directory junction or a symbolic link
> 456: if (IS_WINDOWS) {
> 457: if (!nativeLibLoaded) {
Suggestion: Since this logic to load the FileUtils library is now used twice,
why not move it into a helper method which might also be synchronized (if tests
are executed in parallel).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26631#discussion_r2255022423
