On Thu, 17 Jul 2025 04:35:01 GMT, Volkan Yazici <[email protected]> wrote:
>> src/hotspot/share/opto/library_call.cpp line 963:
>>
>>> 961:
>>> 962: if (bailout->req() > 1) {
>>> 963: if (halt) {
>>
>> Toggle to force a VM crash to be used to surface intrinsic Java wrappers
>> failing to spot invalid input.
>
> @TobiHartmann, this change results in the following compiler error:
>
>
> /home/vy/.../src/hotspot/share/opto/library_call.cpp:958:35: error: invalid
> conversion from 'Node*' to 'RegionNode*' [-fpermissive]
> 958 | generate_negative_guard(offset, bailout);
> | ^~~~~~~
> | |
> | Node*
>
>
> That is, `bailout` is supposed to be of type `RegionNode*`, but
> `_gvn.transform()` returns a value of type `Node*`. bfc301798d1 amends
> failing code with
>
>
> bailout = (RegionNode*) _gvn.transform(bailout);
>
>
> Let me know if you disagree.
Please use `->as_Region()` instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25998#discussion_r2212467404
